Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "block quote" shortcode for blog posts #1

Open
randybuildsthings opened this issue Nov 10, 2014 · 11 comments
Open

Add "block quote" shortcode for blog posts #1

randybuildsthings opened this issue Nov 10, 2014 · 11 comments

Comments

@randybuildsthings
Copy link

We would like to see a field on blog posts that put an excerpt from the blog post body (but could also have a related quote that isn't in the body) into the content of the blog post as a <blockquote> block, fully styled with options to float right or left, width and margin, font-size and line-height.

@colegeissinger
Copy link
Member

Sounds like to me we need a special blockquote shortcode? Something that allows us to easily apply special styling to inline text?

@randybuildsthings
Copy link
Author

Actually, shortcode sounds like a great option, though I was envisioning something that would drop in automatically. Is something already existing that we can use?

@colegeissinger
Copy link
Member

So would you say this is like that big feature block at the top of this post? http://beawimp.org/blog/2014/11/03/coworking-culture-why-coworking-matters/

If you are thinking along those lines, it would be better handled through post meta and dropped into a designated spot in the singular post page. If it was random and may or may not be set, a shortcode would be better.

@randybuildsthings
Copy link
Author

I was originally thinking it would be an automated block that showed in a set place in the blog post (like after the first 100 words or so). If it was a shortcode, couldn't it be that it pulls the post meta for the block quote and then inserts all of the styling so we could put a shortcode in like [featured-quote] and the post would get the whole <blockquote>whatever is in the post meta field, wp_kses() filtered</blockquote>

Styling could be handled then in the CSS rather than inline.

@colegeissinger
Copy link
Member

You can, but it would make more sense to me to do something like this with a shortcode [featured-quote] whatever text you want to display here [/featured-quote]

That will save us from having to query the meta table and the quote itself is within the body content.

@randybuildsthings
Copy link
Author

Yeah, I was trying to get away from modifying the body content, but if we go the shortcode route, your approach works better. Perhaps there's a pre-existing shortcode out there?

@colegeissinger
Copy link
Member

This is a 5 second thing. So do we want a shortcode that we can add to the body content wherever we want or a fixed spot? If it's a fixed spot, post meta is the route. If we want random placement, shortcode is best.

@randybuildsthings
Copy link
Author

I think I want some flexibility in placing it. So shortcode sounds best

Separately, I think I want an "editors notes" post meta that does display as a preface to the post. Kinda like what we did for Natasha's post last week. I'll put a separate issue in for that.

@colegeissinger
Copy link
Member

Ok cool. I feel there is an exisiting meta box we can probably use from Edit Flow for the block you mention.

Just to be clear, the shortcode should just like the block we did for Natasha?

@randybuildsthings
Copy link
Author

The shortcode should look like the block quote that is on Natasha's and Melissa's posts. They were both executed the same way, inside the body of the blog post.

The notes from the editor is not exactly content that would come from Edit Flow. I suppose it could be, however...

@randybuildsthings randybuildsthings changed the title Add "block quote" excerpt post meta Add "block quote" shortcode for blog posts Nov 11, 2014
@randybuildsthings
Copy link
Author

Changed the title to reflect my preference in how this plays out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants