Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.0 release #37

Closed
8 tasks done
ianmkenney opened this issue Jan 27, 2023 · 8 comments
Closed
8 tasks done

2.0.0 release #37

ianmkenney opened this issue Jan 27, 2023 · 8 comments
Assignees
Milestone

Comments

@ianmkenney
Copy link
Member

ianmkenney commented Jan 27, 2023

With #36, the get_propka function is removed. Per the deprecation warning, this means a release of 2.0.0 is needed.

Release checklist

  • addressed all issues for 2.0.0 milestone
  • updated release (PR v2.0.0 #50 )
  • tagged as 2.0.0
  • tested package
  • created new release on GitHub
  • upload to test.pypi.org (create package on test.pypi.org first, add @IAlibay and @orbeckst as admins)
  • test the test.pypi package
  • upload pypi package
@IAlibay IAlibay added this to the Release 2.0.0 milestone Feb 3, 2023
@orbeckst
Copy link
Member

See #20 (comment) for decision to release a version that restricts compatibility to earlier version of PROPKA.

@orbeckst
Copy link
Member

I added a generic release checklist.

@ianmkenney can you please be in charge to create the package on https://test.pypi.org/ for an initial package test. It's a 2.0.0 so let's get the package right first time and not have to do 2.0.1 on pypi immediately...

@ianmkenney we currently do not have an automated deployment workflow so we need to do test.pypi and pypi manually. @IAlibay, have you repackaged your deployment workflows as actions already?

@IAlibay
Copy link
Collaborator

IAlibay commented Feb 14, 2023

@IAlibay, have you repackaged your deployment workflows as actions already?

Unfortunately it's not finished yet, probably would aim for the 2.1 release. To be honest, as long as it uploads to testpypi we shouldn't have too much trouble with packaging here.

Note: we should try to uplaod wheels too if we can.

@ianmkenney
Copy link
Member Author

@IAlibay @orbeckst what are your test pypi usernames?

@IAlibay
Copy link
Collaborator

IAlibay commented Feb 15, 2023

IAlibay I'm a simple person :P

@orbeckst
Copy link
Member

orbeckst commented Feb 15, 2023 via email

@ianmkenney
Copy link
Member Author

@orbeckst @IAlibay should be done

@orbeckst
Copy link
Member

Then go ahead and close the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants