Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change caching to precompiled HTML #8

Merged
merged 28 commits into from
Nov 15, 2022
Merged

Change caching to precompiled HTML #8

merged 28 commits into from
Nov 15, 2022

Conversation

banfai
Copy link
Collaborator

@banfai banfai commented Nov 1, 2022

Fixes #3

@banfai banfai added the enhancement New feature or request label Nov 2, 2022
@banfai banfai added the documentation Improvements or additions to documentation label Nov 2, 2022
@banfai banfai added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Nov 2, 2022
@banfai banfai requested a review from idavydov November 2, 2022 18:40
@banfai banfai added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Nov 2, 2022
@idavydov
Copy link
Collaborator

idavydov commented Nov 8, 2022

@banfai could be related to R version random generator?

Should I review?

@banfai
Copy link
Collaborator Author

banfai commented Nov 8, 2022

@banfai could be related to R version random generator?
R 3.6.0 was released in April 2019, I don't think we've compiled the previous vignettes that long ago 😄

Should I review?
I suppose if we're OK with the differences then yes please.

@julianesiebourg @ingitwetrust do you think it's concerning that the old vignettes are different from the new?
(see #8 (comment) )
Could you please also review?
update: something has changed since the last rendering of the children, @ingitwetrust tried and the rerendering with the old caching yields the same results as the new caching (both are different from the old, but identical to each other)

Copy link
Collaborator

@idavydov idavydov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good, thanks!

@banfai banfai merged commit 3943757 into main Nov 15, 2022
@banfai banfai deleted the simple-vignette-cache branch November 15, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace the current caching approach with cached markdowns
2 participants