Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on/off buttons are reversed #27

Closed
smscotten opened this issue Jun 7, 2011 · 3 comments
Closed

on/off buttons are reversed #27

smscotten opened this issue Jun 7, 2011 · 3 comments

Comments

@smscotten
Copy link

It's a trivial (to fix) issue that's not so trivial for use.

When using the checkbox with class="onoff" the default position is "on." If the checkbox is specified checked, it comes up "off." A checked checkbox should correspond to the switch in the "on" position, not the "off" position.

All that's needed is to modify the style.css file for the .onoff style. Switch the values of background-position in the .onoff style with the values in the .onoff:checked style and it behaves properly.

Thanks!

@thomasyip
Copy link
Member

Thanks for reporting. Will look into it.

@smscotten
Copy link
Author

Sorry, it's only in the Apple theme. The JQT theme has the positions correct. Sorry I didn't check that earlier.

@thomasyip
Copy link
Member

The bug fix was trivial. But, I didn't got a chance to test the extension depending on it.

I didn't really play a lot of attention on the jqt theme.

It should be fixed now. Thanks for reporting the bug again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants