Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve entry group management #27

Closed
14 tasks done
alexbakker opened this issue Dec 18, 2018 · 7 comments
Closed
14 tasks done

Improve entry group management #27

alexbakker opened this issue Dec 18, 2018 · 7 comments
Labels
proposal A proposal for a new feature proposal-accepted An accepted proposal for a new feature

Comments

@alexbakker
Copy link
Member

alexbakker commented Dec 18, 2018

Support for entry groups is fairly basic currently.

  • Create a separate DatabaseEntryGroup object for groups
    • Fields: UUID, Name
  • DatabaseEntry
    • Refer to groups by their UUID instead of their Name
    • Allow assigning an entry to multiple groups
  • EditEntryActivity
    • Allow assigning an entry to multiple groups
  • GroupManagerActivity
    • Require the user to click a "Save" button before actually saving any changes
    • Warn about unsaved changes by showing a "Discard changes?" dialog
    • Add the ability to rename groups
  • MainActivity
    • Support selecting multiple groups to filter on
    • Persist the selected group filter
@alexbakker alexbakker added the proposal-accepted An accepted proposal for a new feature label Dec 18, 2018
@rmunozrodriguez
Copy link

Persist the selected group filter on exit would be great.

@claytondaley
Copy link

I'd really like a top-level groups UI element (i.e. two clicks to pick a group vs 3) to complement the "persist group" suggestion above. I went back to "Authenticator Plus" to see how they do it (atrocious security but I needed groups badly) and I also feel like their menu icon is less fiddly which seems to be due to (1) ~2x the real estate and (2) on the left. I find the smaller icon jammed up against the right edge (i.e. the lip of my case) a lot harder to use.

@OmlineEditor
Copy link

  • Allow assigning an entry to multiple groups

in the drop-down list add a box for selection.

124984265-a9ba7f80-e041-11eb-8631-5ff2d364fb97

@InfiniteCoder06
Copy link
Contributor

InfiniteCoder06 commented Apr 8, 2024

@alexbakker I would be happy to help into this issue

Create a separate DatabaseEntryGroup object for groups

  • Fields: UUID, Name

It looks like this has been implemented right?

Currently working on Renaming of groups

@alexbakker
Copy link
Member Author

It looks like this has been implemented right?

Indeed, I've updated the task list.

@InfiniteCoder06
Copy link
Contributor

@alexbakker Whenever free please do review my PR's

@alexbakker
Copy link
Member Author

Now that #1349 is merged, the checklist is complete. Thanks to everyone who contributed to make this happen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal A proposal for a new feature proposal-accepted An accepted proposal for a new feature
Projects
None yet
Development

No branches or pull requests

5 participants