Support Python 3.8 (fixes #3201) #3202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fantastic and quick work; thank you!! No time like the present to start testing on 3.8, I guess. 😃 🚀 I suppose we should start enabling new Python versions on Appveyor. (For the casual observer: we use Appveyor to test on Windows.) It's somewhat less urgent because Appveyor usually uncovers Windows-specific problems and Travis uncovers Python version-specific problems. But it certainly can't hurt to have the extra coverage! Anyway, this is certainly worth merging now—I'll do that and add a real quick changelog entry. |
sampsyo
added a commit
that referenced
this pull request
Apr 1, 2019
Support Python 3.8 (fixes #3201)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes support for Python 3.8 by conditionally providing a new second argument to
ast.Module.I have added a
py38-testtox environment (and associated-covand-flake8environments) and enabled this on Travis, however I couldn't even see Python 3.7 being tested on AppVeyor. Should both 3.7 and 3.8 be enabled on there?