Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue2205: search for lyrics using part of song title preceding ':' #2206

Merged
merged 6 commits into from
Sep 25, 2016
Merged

Issue2205: search for lyrics using part of song title preceding ':' #2206

merged 6 commits into from
Sep 25, 2016

Commits on Sep 23, 2016

  1. lyrics: reduce code duplication in search_pairs()

    @Kraymer
    Kraymer committed Sep 23, 2016
    Configuration menu
    Copy the full SHA
    4b702b3 View commit details
    Browse the repository at this point in the history

  2. lyrics: search for song title part preceding colon. fix beetbox#2205

    @Kraymer
    Kraymer committed Sep 23, 2016
    Configuration menu
    Copy the full SHA
    8b4f39d View commit details
    Browse the repository at this point in the history

  3. test_lyrics: fix too many blank lines

    @Kraymer
    Kraymer committed Sep 23, 2016
    Configuration menu
    Copy the full SHA
    059be3b View commit details
    Browse the repository at this point in the history

  4. add changelog

    @Kraymer
    Kraymer committed Sep 23, 2016
    Configuration menu
    Copy the full SHA
    7e15ac0 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2016

  1. always yield item artist and title first 

    Rather than using an unordered set for storing pairs, append to a list
and build an OrderedDict from it to filter duplicated strings while
keeping order.
    @Kraymer
    Kraymer committed Sep 25, 2016
    Configuration menu
    Copy the full SHA
    e2703b9 View commit details
    Browse the repository at this point in the history

  2. replace strip_part() by generate_alternatives() 

    Delegate the update of titles and artists lists to the helper
generate_alternatives() function.
    @Kraymer
    Kraymer committed Sep 25, 2016
    Configuration menu
    Copy the full SHA
    7226624 View commit details
    Browse the repository at this point in the history