Use import argument paths as bytestrings on Python 3 #2803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampsyo
added a commit
that referenced
this pull request
Feb 5, 2018
Use import argument paths as bytestrings on Python 3
sampsyo
added a commit
that referenced
this pull request
Feb 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address #2793, where, on Python 3 under a limited locale, the path arguments to the
importcommand can have surrogate escapes in them. This converts thesestrarguments to the standard beets representation for paths, which isbytesvalues.I wasn't able to reproduce the problem on my machine, but I'm pretty sure this is the right fix.