Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaygain: target level refactor #3065

Merged
merged 9 commits into from
Jul 25, 2019

Commits on Jul 22, 2019

  1. fix bs1770gain test

    This test caused other tests to fail due to missing cleanup.
    zsinskri committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    b9063a0 View commit details
    Browse the repository at this point in the history
  2. replaygain: pass target_level and peak to backends

    Configure the replaygain analysis by passing arguments to the Backends. This
    avoids the difference between ReplayGain and EBU r128 backends; every Backend
    can now fulfil both tasks. Additionally it eases Backend development as the
    difference between the two tag formats is now completely handled in the main
    Plugin, not in the Backends.
    zsinskri committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    0c8eead View commit details
    Browse the repository at this point in the history
  3. replaygain: targetlevel and peak_method depends on tag format

    Allow to configure the target level for R128_* tags separately from REPLAYGAIN_*
    tags and skip peak calculation for R128_* tags if possible.
    zsinskri committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    e7e2c42 View commit details
    Browse the repository at this point in the history
  4. replaygain: add target_level test

    Assert that analysing the same track with different target levels yields
    different gain adjustments.
    zsinskri committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    5a8bdb6 View commit details
    Browse the repository at this point in the history
  5. replaygain: add R128_* tag test

    Assert that the replaygain plugin does not write REPLAYGAIN_* tags but R128_*
    tags, when instructed to do so.
    
    This test is skipped for the `command` backend as it does not support OPUS.
    zsinskri committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    88ab547 View commit details
    Browse the repository at this point in the history
  6. update replaygain target level documentation

    - document `r128_targetlevel`
    - explain difference between `targetlevel` and `r128_targetlevel`
    - deprecate `method` option: use `targetlevel` instead.
    zsinskri committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    fbc8cc4 View commit details
    Browse the repository at this point in the history
  7. changelog: new r128_targetlevel option

    Add changelog entries for the introduction of the `r128_targetlevel`
    configuration option, superseding the `method` option.
    zsinskri committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    da602d7 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2019

  1. apply suggested improvements

    Apply improvements suggested in GitHub PullRequest beetbox#3065:
    - be idiomatic
      - 0 is falsy
      - check enum equality, not identity
      - mutate list by constructing a new one
    - improve documentation
      - fix a typo
      - do not mention deprecation of a config option
    zsinskri committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    a9f70f8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e3645df View commit details
    Browse the repository at this point in the history