More https changes #3297
Merged
More https changes #3297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure where these are used, but the website supports https and the API url already uses https, so this should be a safe call and not require a util.SNI_SUPPORTED check.
Should really be all now (pending the next commit).
I'm unsure regarding the pygst tutorial, so I just added another URL of the best resource I could find with a quick web search.
|
Cool; thanks! Thanks especially much for tracking down the new URLs for source repositories that have moved around. I've done the thing where I remove the custom domain from the Pages settings and re-add it. (I've also updated the DNS entries for beets.io to point to the new CDN servers.) The certificate still doesn't seem to be valid, but I'd be willing to believe this could take a while to set up, so let's see what happens. |
|
Yes, it may take little while to be updated. I suppose if it doesn't work within a day or so, you could contact support. |
|
Once that works, I can update all the references to |
|
Actually, it works already for me, so 🎉 |
|
Oh yeah! It just started working for me too. |
FichteFoll
added a commit
to FichteForks/beets
that referenced
this pull request
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #3296. See commit messages for details.
This time I also changed/added a couple references in code.
Regarding beets.io, you'll probably need to update your gh-pages settings to remove the custom domain name and then set it again so that Github will create a proper certificate for your domain. They support this for about a year now.