Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to the latest 3.10 release #4092

Merged
merged 11 commits into from
Jun 14, 2022
Merged

Conversation

arogl
Copy link
Contributor

@arogl arogl commented Oct 5, 2021

Description

Updates CI to latest 3.10 release

@wisp3rwind
Copy link
Member

Maybe let's wait for the first Python 3.11 alpha to hit github actions (should be soon: https://www.python.org/dev/peps/pep-0664/) so that we can keep the current structure of the configuration?

@sampsyo
Copy link
Member

sampsyo commented Oct 5, 2021

According to the CI results, it looks like the name of the version may be "3.10" rather than "3.10.0"?

@arogl
Copy link
Contributor Author

arogl commented Oct 5, 2021

My first attempt was just for 3.10, but the CI system interpreted that as 3.1

@wisp3rwind
Copy link
Member

My first attempt was just for 3.10, but the CI system interpreted that as 3.1

Add quotes: actions/setup-python#249 (comment)

@arogl
Copy link
Contributor Author

arogl commented Oct 6, 2021

Not sure why coverage failed on 3.9, windows, when it has worked on other requests.

@wisp3rwind
Copy link
Member

Not sure why coverage failed on 3.9, windows, when it has worked on other requests.

I had a brief look at the log: The test in question spawns another process running the bpd daemon, which does indeed access the file that could not be deleted. Presumably, in

server.join(timeout=0.2)

the timeout can occasionally be too short if something blocks the process. Then, the daemon has not yet quit on test teardown. We may want to increase that timeout a little (1-2 seconds? This is only a safeguard in case the daemon actually locks up, so making it quite long shouldn't be a problem) to make the test more reliable.

@sampsyo
Copy link
Member

sampsyo commented Oct 7, 2021

Arg! Yeah, extending that timeout seems like a good idea. In the mean time, I have restarted the job to roll the dice again and hope for the best…

@stale
Copy link

stale bot commented Feb 5, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 5, 2022
@arogl
Copy link
Contributor Author

arogl commented Feb 5, 2022

This should be merged and a new PR for 3.11-a05

@stale stale bot removed the stale label Feb 5, 2022
@wisp3rwind
Copy link
Member

This should be merged and a new PR for 3.11-a05

I think it would be easier to update this PR to include the 3.11 alpha. Splitting the PR would mean switching the logic for older/current/upcoming Python versions back and forth. Do you have the time to do the update?

Copy link
Member

@wisp3rwind wisp3rwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arogl for taking care of this. I have one comment about hardcoding the specific versions, which if possible would be nice to avoid for easier maintenance.

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@wisp3rwind
Copy link
Member

Any ideas why the last commit didn't trigger the CI?

I've found some documentation on specifying python versions at https://github.com/actions/setup-python#usage, apparently the "canonical" way to require the latest pre-release is a range specification like python-version: '3.11.0-alpha - 3.11.0'.

@sampsyo
Copy link
Member

sampsyo commented Feb 6, 2022

Weird about Actions not being triggered… I'm also stumped?

Using the range specifier for the Python version seems like a cool idea (since it will avoid becoming out of date as releases happen).

@stale
Copy link

stale bot commented Jun 12, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 12, 2022
@wisp3rwind
Copy link
Member

Any ideas why the last commit didn't trigger the CI?

I've found some documentation on specifying python versions at https://github.com/actions/setup-python#usage, apparently the "canonical" way to require the latest pre-release is a range specification like python-version: '3.11.0-alpha - 3.11.0'.

@arogl, would you have the time to update the PR accordingly?

@stale stale bot removed the stale label Jun 12, 2022
@arogl
Copy link
Contributor Author

arogl commented Jun 13, 2022

Any ideas why the last commit didn't trigger the CI?
I've found some documentation on specifying python versions at actions/setup-python#usage, apparently the "canonical" way to require the latest pre-release is a range specification like python-version: '3.11.0-alpha - 3.11.0'.

@arogl, would you have the time to update the PR accordingly?

@wisp3rwind I have updated to use the -dev option and dropped Python 3.6

@wisp3rwind
Copy link
Member

Thanks!

We do still support Python 3.6, don't we? I think we should keep testing it then.

@arogl
Copy link
Contributor Author

arogl commented Jun 14, 2022

Thanks!

We do still support Python 3.6, don't we? I think we should keep testing it then.

3.6 has been dropped from support since Sept 2021

https://peps.python.org/pep-0494/

@wisp3rwind wisp3rwind mentioned this pull request Jun 14, 2022
@wisp3rwind
Copy link
Member

Fair enough. Then we should drop Python 3.6 entirely (see the new issue I just opened).

@wisp3rwind wisp3rwind merged commit 154e5eb into beetbox:master Jun 14, 2022
@arogl arogl deleted the python310 branch May 5, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants