Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with pillow 10 #4868

Merged
merged 1 commit into from Aug 10, 2023
Merged

Conversation

mweinelt
Copy link
Contributor

@mweinelt mweinelt commented Aug 5, 2023

The ANTIALIAS attribute has long been deprecated, and was finally removed in pillow 10.0.

The recommendation is to migrate to Resampling.LANCZOS instead.

https://pillow.readthedocs.io/en/stable/deprecations.html#constants

Description

Fixes #X.

(...)

To Do

  • Documentation. (If you've add a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst near the top of the document.)
  • Tests. (Encouraged but not strictly required.)

@wisp3rwind
Copy link
Member

Thanks for catching this!

Would you mind adding a changelog entry so that people who run into this issue can find the solution by searching through the log?

(For reference: The LANCZOS constant was added in Pillow 1.1.3 which was released in 2010, so I think we should be fine without explicitly stating any version requirement in setup.py).

@jackwilsdon jackwilsdon linked an issue Aug 6, 2023 that may be closed by this pull request
The `ANTIALIAS` attribute has long been deprecated, and was finally
removed in pillow 10.0.

The recommendation is to migrate to `Resampling.LANCZOS` instead.
@mweinelt
Copy link
Contributor Author

mweinelt commented Aug 7, 2023

Added to the changelog. PTAL.

@wisp3rwind wisp3rwind merged commit 290c1df into beetbox:master Aug 10, 2023
14 checks passed
@wisp3rwind
Copy link
Member

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pillow 10.0.0 deprecates Image.ANTIALIAS in util/artresizer.py
2 participants