Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not run coverage by default #5312

Merged
merged 2 commits into from
Jun 16, 2024
Merged

Do not run coverage by default #5312

merged 2 commits into from
Jun 16, 2024

Conversation

snejus
Copy link
Member

@snejus snejus commented Jun 15, 2024

Fixes #5242.

This PR moves coverage measurement from the default pytest invocation to a separate action test-with-coverage.

@snejus snejus self-assigned this Jun 15, 2024
@snejus snejus requested a review from Serene-Arc June 15, 2024 22:55
@snejus snejus mentioned this pull request Jun 15, 2024
Closed
bal-e
bal-e approved these changes Jun 15, 2024
View reviewed changes
Copy link
Member

@bal-e bal-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Also, I just confirmed locally that -p no:cov is safe to pass to pytest even when pytest-cov isn't installed.

@snejus snejus merged commit 076ec6f into master Jun 16, 2024
13 checks passed
@snejus snejus deleted the do-not-run-coverage-by-default branch June 16, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bal-e bal-e bal-e approved these changes

@Serene-Arc Serene-Arc Awaiting requested review from Serene-Arc

Assignees

@snejus snejus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code coverage baked into setup.cfg breaks Gentoo Portage builds/testing
2 participants
@snejus @bal-e