Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Spyke dependency #13

Open
pilaf opened this issue Jun 17, 2019 · 0 comments
Open

Remove Spyke dependency #13

pilaf opened this issue Jun 17, 2019 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@pilaf
Copy link
Collaborator

pilaf commented Jun 17, 2019

Instead of having Spyke as a dependency that we patch on top of, copy the relevant bits of Spyke into this gem and modify it as needed. This should give us a lot more flexibility going forward.

Things we may want to do once we break free of Spyke:

  • Rename Model#id to Model#record_id
  • Alias Model.query as Model.where

Note: this will require adding specs for all of Spyke's features, which we currently don't have as we trust that Spyke tests those itself.

@pilaf pilaf added the enhancement New feature or request label Jun 17, 2019
@pilaf pilaf added this to the 1.0 milestone Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant