Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating ExampleNode outline title is never passed to contructor #197

Closed
latvianization opened this issue Feb 3, 2021 · 4 comments
Closed

Comments

@latvianization
Copy link
Contributor

broken in #161
dfc47a2#diff-6e02ff2c049819aa5946c6a1577b66c4ebece9a0c2275c5aa5f7c5d209e9eba2R227

title is never passed

@ciaranmcnulty
Copy link
Contributor

Hm, what is the effect of this for end users?

Is it just a 1-line change to put it back?

@latvianization
Copy link
Contributor Author

it is one line fix, just tested and outline title is set as it was previously

$examples[] = new ExampleNode( $exampleTable->getRowAsString($rowNum + 1), array_merge($this->tags, $exampleTable->getTags()), $this->getSteps(), $row, $exampleTable->getRowLine($rowNum + 1), $this->getTitle() );

We use outline text as part of hash to save test run in custom test reporting system. If title is not provided, it is empty string which leads to identical hashes for all outline examples which then messes up our reports

@ciaranmcnulty
Copy link
Contributor

Any chance you can PR? You can even do it via the Github UI :)

@latvianization
Copy link
Contributor Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants