TagFilter not checking for empty string #250
Comments
magikid
added a commit
to magikid/Gherkin
that referenced
this issue
Apr 26, 2022
If the `filterString` in `TagFilter` is an empty string, an exception was being thrown because the code was expecting a non-empty string. This checks if the string is non-empty and returns early if it is. Issue: Behat#250
magikid
added a commit
to magikid/Gherkin
that referenced
this issue
Apr 26, 2022
If the `filterString` in `TagFilter` is an empty string, an exception was being thrown because the code was expecting a non-empty string. This checks if the string is non-empty and returns early if it is. Issue: Behat#250
ciaranmcnulty
pushed a commit
that referenced
this issue
Jul 7, 2022
* Check for empty Tag filter string If the `filterString` in `TagFilter` is an empty string, an exception was being thrown because the code was expecting a non-empty string. This checks if the string is non-empty and returns early if it is. Issue: #250 * Use strlen instead of mb_strlen strlen is O(1) and mb_strlen is O(n).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When I run
behat --tags=""then I expect no exceptions to be thrown. In the version of behat that I'm running (3.8.1), it throws the following exception:It looks like
TagFilterdoesn't check for the empty string before exploding the string and attempting to use array access on it.The text was updated successfully, but these errors were encountered: