Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature_request(message): More customizable sentiment-bot message #25

Open
Kristinita opened this issue Apr 9, 2018 · 2 comments
Open

Comments

@Kristinita
Copy link

1. Summary

It would be nice, if user can customize this part of Sentiment Bot message:

Keep in mind, this repository uses the Contributor Covenant.

Now user can't change this text.

2. Argumentation

More customization — always good.

User can want to:

  1. use another message instead of Keep in mind, this repository uses the Contributor Covenant,
  2. using [**bold links**](http://example.link) instead of [**link**](http://example.link).

3. Example of expected behavior

If in config.yml:

sentimentBotReplyComment: |
  Please be sure to review the code of conduct and be respectful of other users. cc/ @Kristinita

  [**CODE_OF_CONDUCT.md**](https://<link to CODE_OF_CONDUCT>) for this repository.

sentiment-bot will use [**CODE_OF_CONDUCT.md**](https://<link to CODE_OF_CONDUCT>) for this repository. instead of Keep in mind, this repository uses the Contributor Covenant.

Thanks.

@hiimbex
Copy link
Member

hiimbex commented Apr 10, 2018

Right now, the code only appends that line if the repository has a code of conduct, so that way if the link or kind of code of conduct change, they wouldn't need to change their config file, since this information is from the GitHub API.

However, I'm not opposed to implementing a way to turn this off, but I wouldn't wanna break the functionality for existing users who desire this functionality. Would you be interested in implementing this change?

@Kristinita
Copy link
Author

if the link or kind of code of conduct change

I don't think, that this will occur frequently. Example: I create a file CODE_OF_CONDUCT.md, when I create new repository, → then I don't deal with this file.

but I wouldn't wanna break the functionality for existing user

Yes, sentimentBotReplyComment: key exist in 64 repositories at the time.

Maybe would be better this behavior?

↓↓↓

If sentimentBotFooterComment key exist:

    will accept value of sentimentBotFooterComment key.

else:

    will accept Keep in mind, this repository uses the Contributor Covenant.

This will not affect users who already uses Sentiment Bot.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants