Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i-bem.bemhtml: Nested mixes work inconsistent for mods of same block #807

Closed
tadatuta opened this issue Jan 18, 2015 · 6 comments
Closed
Labels

Comments

@tadatuta
Copy link
Member

bemjson:

{
    block: 'b1',
    mix: { block: 'b2' }
}

Case 1
bemhtml:

block('b2').mix()({ block: 'b3', mods: { m1: 'v1' } });

the result will have b3_m1_v1.

Case 2
bemhtml:

block('b2').mix()({ block: 'b1', mods: { m1: 'v1' } });

the result won't have b1_m1_v1.

@veged
Copy link
Member

veged commented Jan 29, 2015

are you sure about your test cases? seems like any block('b2').mix()... doesn't work for { block: 'b1', mix: { block: 'b2' } }

@tadatuta
Copy link
Member Author

@veged that's another issue which is filed here.

I wanted to show that when you try to mix same block with modifier in BEMHTML, the result is different from modifier of any other block.

@veged
Copy link
Member

veged commented Jan 29, 2015

I just try to reproduce and fail with it. Could you please add tests to https://github.com/bem/bem-core/tree/v2/common.blocks/i-bem/i-bem.test.bemhtml ?

@tadatuta
Copy link
Member Author

@veged I think you weren't able to reproduce because of this bug #873

@veged veged added the ready label May 19, 2015
@veged
Copy link
Member

veged commented Apr 6, 2016

is it still relevant and not fixed in bem-xjst?

@tadatuta
Copy link
Member Author

Closing in favour of bem/bem-xjst#241

@tadatuta tadatuta removed the ready label Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants