This repository has been archived by the owner on Sep 21, 2022. It is now read-only.
html-reporter: Made background switchable #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
unlok
changed the title
|
@SevInf, проверь, пожалуйста. Я так и не могу получить отчет из-за: |
|
@unlok нужен ребейз. И еще jscss ругается на кодстайл. |
| @@ -19,6 +19,11 @@ | |||
|
|
|||
| {{#if success}} | |||
| <div class="image-box"> | |||
| <div class="cswitcher"> | |||
There was a problem hiding this comment.
data-id же не используется в коде?
|
А можешь скриншотов для истории приложить? |
| handleColorSwitch( | ||
| target, | ||
| filter.call(target.parentNode.childNodes, function(node) { | ||
| return node.nodeType === 1; |
There was a problem hiding this comment.
вместо magic numbers лучше использовать именованные константы. Здесь Node.ELEMENT_NODE
|
Выглядит так: |
| @@ -26,10 +27,39 @@ | |||
| }); | |||
| } | |||
|
|
|||
| function handleColorSwitch(target, sources) { | |||
| var imageBox = target.parentNode.parentNode; | |||
There was a problem hiding this comment.
Как-то хрупко выглядит. Может лучше сразу искать ноду с классом .image-box, чтоб не развалилось при смене верстки
|
В остальном 🆗 |
2 similar comments
1 similar comment
SevInf
pushed a commit
that referenced
this pull request
Apr 15, 2015
html-reporter: Made background switchable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.