Refactor online system + personal records #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,6 +19,9 @@ export default React.createClass({ | |||
| song.tutorial | |||
| ? <div className="MusicListItemのtutorial">Tutorial</div> | |||
| : <div className="MusicListItemのinfo"> | |||
| <div className="MusicListItemのcharts"> | |||
| {this.renderChartlist(song.charts)} | |||
Because of weird bug where nested flexbox gets an inferred flex-basis of 0. Therefore, resorting back to use floats.
| [getRecord川], () => doGetRecord川, | ||
| [unauthenticated川], () => doGetUnauthenticated川 | ||
| ) | ||
| let operationTransition川 = operation川.flatMapLatest(performWithOperation) |
There was a problem hiding this comment.
You can do it without operationTransition川
NEED MORE TEST COVERAGE! MOCK!! STUB!!! MASH!!!! SMASH!!!!! BASH!!!!!! AAAHHAHHAHAHAHHHHHH!!!!!!! |
dtinth
changed the title
|
Problem with this implementation:
Looking at structuring our data, maybe we can make it so that |
|
A cleaner architecture may be like this:
|
This needs MOAR tests
dtinth
force-pushed
the
online-refactor
branch
from
c99cd9c
to
9d822f6
Compare
dtinth
force-pushed
the
online-refactor
branch
from
9d822f6
to
de2adea
Compare
dtinth
added a commit
that referenced
this pull request
Nov 3, 2015
Refactor online system + personal records
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the online system code is a spaghetti.
In order to implement more advanced features, such as, fetching the record from the cloud server, and stuff like that… I first need to clean up the existing code.
THIS PR IS GETTING BIG
The scope of this PR, so let’s define the scope:
OUT OF SCOPE DON"T DO IT