Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates usage of co to async function in scintillator/loader.js #643

Merged
merged 1 commit into from
May 3, 2020
Merged

Updates usage of co to async function in scintillator/loader.js #643

merged 1 commit into from
May 3, 2020

Conversation

mslourens
Copy link
Contributor

@mslourens mslourens commented Oct 2, 2019

fixes #637

Changelog

Migrate part of the code from co to async functions

@codecov-io
Copy link

codecov-io commented Oct 2, 2019

Codecov Report

Merging #643 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #643      +/-   ##
==========================================
+ Coverage   80.85%   80.85%   +<.01%     
==========================================
  Files         156      156              
  Lines        4764     4770       +6     
  Branches      184      184              
==========================================
+ Hits         3852     3857       +5     
- Misses        863      864       +1     
  Partials       49       49
Impacted Files Coverage Δ
src/scintillator/loader.js 85.36% <100%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff90d37...a4e2efa. Read the comment docs.

Copy link
Member

@dtinth dtinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to Bemuse project! 😄

@dtinth dtinth added c:ready category:Internals to merge This PR will be included in the next release and removed c:ready labels Oct 3, 2019
@dtinth dtinth merged commit 5ca0279 into bemusic:master May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:Internals to merge This PR will be included in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert the load function to async function (instead of using co) in src/scintillator/loader.js
3 participants