Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐙 Migrate part of the code from co to async functions #655

Merged
merged 27 commits into from
May 3, 2020
Merged

Conversation

dtinth
Copy link
Member

@dtinth dtinth commented Oct 4, 2019

Changelog

Migrate part of the code from co to async functions. (#639, by [@TayHobbs]; #641, #642, #643, #645, #649, by [@mslourens]; #646, by [@setheal]; #652, by [@511V41]; #656, by [@aboudicheng]; #657, by [@pnkapadia64]).

release-train bot added a commit that referenced this pull request Feb 3, 2020
@codecov-io
Copy link

codecov-io commented Feb 3, 2020

Codecov Report

Merging #655 into master will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #655      +/-   ##
==========================================
+ Coverage   80.91%   81.07%   +0.15%     
==========================================
  Files         156      156              
  Lines        4757     4776      +19     
  Branches      184      184              
==========================================
+ Hits         3849     3872      +23     
+ Misses        859      855       -4     
  Partials       49       49              
Impacted Files Coverage Δ
src/game/display/player-display.js 77.06% <100.00%> (+1.23%) ⬆️
src/scintillator/index.spec.js 99.60% <100.00%> (-0.40%) ⬇️
src/scintillator/loader.js 85.36% <100.00%> (-0.35%) ⬇️
src/scintillator/nodes/if.js 94.73% <0.00%> (+10.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e167fb...5f5707f. Read the comment docs.

release-train bot added a commit that referenced this pull request Feb 3, 2020
release-train bot added a commit that referenced this pull request Feb 3, 2020
release-train bot added a commit that referenced this pull request Feb 3, 2020
release-train bot added a commit that referenced this pull request Feb 3, 2020
release-train bot added a commit that referenced this pull request Mar 1, 2020
release-train bot added a commit that referenced this pull request Mar 1, 2020
release-train bot added a commit that referenced this pull request Mar 1, 2020
@sonarcloud
Copy link

sonarcloud bot commented Mar 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented May 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

release-train bot added a commit that referenced this pull request May 3, 2020
@dtinth dtinth merged commit 36a10db into master May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants