Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates usage of co to async function in src/scintillator/index.spec.js #652

Closed
wants to merge 3 commits into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Oct 3, 2019

fixes #636

P.S. I'm glad to committing to Bemuse because I'm beatmania IIDX player in Japan :)

Changelog

Migrate part of the code from co to async functions

@ghost ghost changed the title Updates usage of co to async function in src/scintillator/index.spec.js [WIP] Updates usage of co to async function in src/scintillator/index.spec.js Oct 3, 2019
@ghost ghost changed the title [WIP] Updates usage of co to async function in src/scintillator/index.spec.js Updates usage of co to async function in src/scintillator/index.spec.js Oct 3, 2019
@ghost
Copy link
Author

ghost commented Oct 3, 2019

I think that we can ignore issues that is raised by codeclimate.
It saying "Similar blocks of code found in 2 locations. Consider refactoring" but they are obvious no problem.

Copy link
Member

@dtinth dtinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the tests pass, so it seems to work! You are right about CodeClimate, we can ignore it for this change, since the code is objectively better than before, I’m approving this.

Thanks for contributing to Bemuse project! 😄

I will be playing songs in BOFXV (a big BMS event in Japan) and will be leaving some impressions. So maybe see you there! :D

@dtinth dtinth added c:ready category:Internals to merge This PR will be included in the next release and removed c:ready labels Oct 3, 2019
@codecov-io
Copy link

codecov-io commented Oct 22, 2019

Codecov Report

Merging #652 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
+ Coverage   80.91%   80.99%   +0.07%     
==========================================
  Files         156      156              
  Lines        4757     4782      +25     
  Branches      184      184              
==========================================
+ Hits         3849     3873      +24     
- Misses        859      860       +1     
  Partials       49       49
Impacted Files Coverage Δ
src/scintillator/index.spec.js 99.6% <100%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30dbbe2...3b9b717. Read the comment docs.

@dtinth
Copy link
Member

dtinth commented Oct 19, 2022

Closing as I just realized that this PR has already been cherry-picked into master — df0e85a

@dtinth dtinth closed this Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:Internals hacktoberfest-accepted to merge This PR will be included in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert all co.wrap() calls in src/scintillator/index.spec.js to async functions
3 participants