Cleanup #12
Merged
Cleanup #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendichter
reviewed
Nov 2, 2019
metafile.yaml
Outdated
| ElectrodeGroup: | ||
| description: description | ||
| device: Device | ||
| description: '' |
There was a problem hiding this comment.
I don't like empty strings. In the past they have caused errors on read, if a checker asks if obj.description, meaning to check if it is None, but also checking if it is an empty string. If a field as required, then we should either add it ourselves or require that a user add it.
There was a problem hiding this comment.
Understood. I changed it for ElectrodeGroup description.
src/buffalonwb/conversion_module.py
Outdated
| lfp_mat_path = None | ||
| behavior_file = None | ||
| sorted_spikes_nex5_file = None | ||
| for k, v in source_paths.items(): |
There was a problem hiding this comment.
Not a big deal but it's a bit odd to iterate over the dictionary here. It would be more natural to do e.g. if 'raw Nlx' in source_paths:
There was a problem hiding this comment.
I agree - that's odd (I didn't write it). That is changed and cleaner now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up argument parsing, input checking, and minor things unrelated to the conversion.