Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop bridging JSValues #15

Closed
ben-ng opened this issue Mar 30, 2015 · 1 comment
Closed

Stop bridging JSValues #15

ben-ng opened this issue Mar 30, 2015 · 1 comment
Labels
enhancement

Comments

@ben-ng
Copy link
Owner

ben-ng commented Mar 30, 2015

According to the time profiler, bridging a JSValue to Obj-C and working with it in native code turns out to be really slow as the value gets more complex. While bundling babelify, 550ms is spent just bridging one AST to obj-c, which is time wasted. An effort should be made to limit bridging to two places per dependency -- transferring the source code to be parsed, and receiving the resolved require expressions and literals.

screen shot 2015-03-30 at 12 55 01 am
@ben-ng
Copy link
Owner Author

ben-ng commented Mar 31, 2015

Done in cdbf0b5. It doubled paq's speed, which is now 4x faster than browserify.

@ben-ng ben-ng closed this as completed Mar 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ben-ng