Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second attempt to fix issue #88, so that demo is easy to run for peop… #104

Merged
merged 1 commit into from
Feb 13, 2017

Conversation

jstafford
Copy link
Contributor

…le checking out the project

@jstafford
Copy link
Contributor Author

  • I changed the http-server port from 8081 to 3000, because it was listed as 8080 in the Readme, so I needed to make some change, and it seemed like 3000 was a much more standard port to find node projects on. Feel free to switch back to 8081 if you like that better.
  • I added a favicon (from create-react-app) because I was tired of seeing the 404 at app startup, and I run with a lot of tabs open, so I like to have icons I recognize to look for, since the names get truncated.
  • I added two extra lines to the instructions in the readme for how to run the demo because I'm an over explainer, and because if you literally had just followed the previous step on how to install, you would have to do something before the instruction on how to run the demo would work. Rather than tell them to cd into the node_modules directory, I thought it better to tell them to clone it. I know no one needs instruction on how to clone, but sometimes it's nice to just copy a set of commands that have the urls correct, and not have to go back and grab them from wherever. Feel free to delete these lines if they bug you.

@codecov-io
Copy link

codecov-io commented Feb 13, 2017

Codecov Report

Merging #104 into master will increase coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #104     +/-   ##
=========================================
+ Coverage   76.94%   77.05%   +0.1%     
=========================================
  Files         112      112             
  Lines        2733     2733             
  Branches      283      283             
=========================================
+ Hits         2103     2106      +3     
+ Misses        418      414      -4     
- Partials      212      213      +1
Impacted Files Coverage Δ
src/components/layout/FixedHeader.jsx 51.79% <ø> (-0.72%)
src/components/plugins/editor/Inline.jsx 85.54% <ø> (+4.81%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a049b4...fd99c17. Read the comment docs.

@bencripps
Copy link
Owner

Changes look good, and I like the simplicity of running a single command. Thanks for taking a look at this!

@bencripps bencripps merged commit 81f5096 into bencripps:master Feb 13, 2017
@jstafford jstafford deleted the bug-startdemo branch February 13, 2017 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants