Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm run demo fails to work properly #88

Closed
jstafford opened this issue Feb 6, 2017 · 3 comments
Closed

npm run demo fails to work properly #88

jstafford opened this issue Feb 6, 2017 · 3 comments
Labels

Comments

@jstafford
Copy link
Contributor

Steps to reproduce:

  1. Make a local clone of the react-redux-grid:
$ git clone https://github.com/bencripps/react-redux-grid.git
$ cd react-redux-grid
  1. Follow the steps in the "Installation" section of README.MD to build and run the demo:
$ npm install
$ npm run demo
  1. Open your browser pointed to http://localhost:8080

Observed behavior:

  • A blank page loads in the browser, and the following error is displayed in the terminal, "GET /demo/lib/bundle.js" Error (404): "Not found"

Expected behavior:

  • The grid displays in the browser, and there is no error.

Note: I have a simple fix for this issue and will be submitting it immediately.

@bencripps bencripps added the bug label Feb 6, 2017
jstafford added a commit to jstafford/react-redux-grid that referenced this issue Feb 6, 2017
…hat npm run demo works properly, and remove bundle.js from version control for cleanliness sake
jstafford added a commit to jstafford/react-redux-grid that referenced this issue Feb 6, 2017
… and remove the generated file bundle.js from source control for cleanliness sake
bencripps added a commit that referenced this issue Feb 6, 2017
fix issue #88 by fixing the path to bundle.js in index.html,
@algbeta
Copy link

algbeta commented Feb 9, 2017

Hey guys!
Is the fix merged already?
Demo still fails for me.

@bencripps
Copy link
Owner

This has been fixed atleast for my workflow. First off, the demo won't load unless you also have the hot-reloader also loading, which is triggered by npm run hot

$ npm run demo:run
$ npm run hot

And you should have it work -- @jstafford let me know if there is another way you envisioned this working?

@jstafford
Copy link
Contributor Author

@bencripps What do you think about adding a new script called "start" that starts both hot and demo, like people might be used to with a create-react-app based project? Then changing the readme to suggest that if they want to play with it, that they just do npm install, npm run start? Certainly the readme is misleading as it is currently written. When I put my fix in, I wasn't even thinking about hot reloading, I was just trying to make it work as the instructions were written in the readme. It makes a lot more sense to have hot reloading, so I see why you backed out my change to the path to bundle.js. I'm going to make a pull request and you can give me some feedback if you want to change it around a little.

jstafford added a commit to jstafford/react-redux-grid that referenced this issue Feb 13, 2017
bencripps added a commit that referenced this issue Feb 13, 2017
Second attempt to fix issue #88, so that demo is easy to run for peop…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants