-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npm run demo fails to work properly #88
Comments
…hat npm run demo works properly, and remove bundle.js from version control for cleanliness sake
… and remove the generated file bundle.js from source control for cleanliness sake
fix issue #88 by fixing the path to bundle.js in index.html,
Hey guys! |
This has been fixed atleast for my workflow. First off, the demo won't load unless you also have the $ npm run demo:run
$ npm run hot And you should have it work -- @jstafford let me know if there is another way you envisioned this working? |
@bencripps What do you think about adding a new script called "start" that starts both hot and demo, like people might be used to with a create-react-app based project? Then changing the readme to suggest that if they want to play with it, that they just do npm install, npm run start? Certainly the readme is misleading as it is currently written. When I put my fix in, I wasn't even thinking about hot reloading, I was just trying to make it work as the instructions were written in the readme. It makes a lot more sense to have hot reloading, so I see why you backed out my change to the path to bundle.js. I'm going to make a pull request and you can give me some feedback if you want to change it around a little. |
… for people checking out the project
Second attempt to fix issue #88, so that demo is easy to run for peop…
Steps to reproduce:
$ git clone https://github.com/bencripps/react-redux-grid.git $ cd react-redux-grid
Observed behavior:
"GET /demo/lib/bundle.js" Error (404): "Not found"
Expected behavior:
Note: I have a simple fix for this issue and will be submitting it immediately.
The text was updated successfully, but these errors were encountered: