Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to determine where musl is determined based on the target vendor being alpine or not #65

Open
bjorn3 opened this issue Jan 9, 2023 · 0 comments

Comments

@bjorn3
Copy link

bjorn3 commented Jan 9, 2023

This is wrong when trying to use a rustup installed rustc on alpine or when globally installing musl on a non-alpine system. I would suggest always assuming that musl is globally installed and if this isn't the case ask the user to manually pass in the required -Clink-args required to make the linker find musl. This is necessary anyway for other crates like libc to work and it will allow it to work with the musl copy shipped with rustc itself when statically linking. For determining if static or dynamic linking should be used, checking the presence of the crt-static target feature works much better as this is what actually determines if libc will be statically linked or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant