You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm having issues in some diagrams where labels are long and don't containt spaces (15 characters), so text doesn't get wrapped and part of it gets hidden outside of the SVG's area. Margins in the svg should fix this problem, but are not supported by venn.js.
Also, I need to specify other attributes to the svg element, like viewbox and preserveAspectRatio.
It seems more logical to me to pass a selector to an svg element to venn.js, instead of having venn.js create the svg element itself. What do you think?
I agree that the API here needs some work. Passing in a selector makes sense - but I was thinking about going even farther and trying to model the API like: http://bost.ocks.org/mike/chart/ (which also satisfies #4). I've started on this, but probably won't be able to finish this soon because of an upcoming work deadline.
In the short term, you can modify the SVG being returned to add the margin - or you can increase the whitespace around the diagram by passing in a 'padding' param like :venn.drawD3Diagram(element, dataset, width, height, {'padding' : 50} ).
I'm having issues in some diagrams where labels are long and don't containt spaces (15 characters), so text doesn't get wrapped and part of it gets hidden outside of the SVG's area. Margins in the svg should fix this problem, but are not supported by venn.js.
Also, I need to specify other attributes to the
svg
element, likeviewbox
andpreserveAspectRatio
.It seems more logical to me to pass a selector to an svg element to venn.js, instead of having venn.js create the svg element itself. What do you think?
I've refactored in Mango-information-systems/venn.js@6dd277608c6, let me know if I should send you a PR.
P.S.: Great work! Thanks for creating this library.
The text was updated successfully, but these errors were encountered: