Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emails with Unicode inside them are detected #17

Closed
benjojo opened this issue Dec 15, 2013 · 2 comments
Closed

Emails with Unicode inside them are detected #17

benjojo opened this issue Dec 15, 2013 · 2 comments

Comments

@benjojo
Copy link
Contributor

benjojo commented Dec 15, 2013

This should not happen as of the RFC

an example to test by is
あいうえお@example.com
@kitten
Copy link
Contributor

kitten commented Dec 16, 2013

#19 and #20 should have fixed this.

@benjojo
Copy link
Contributor Author

benjojo commented Dec 16, 2013

Nice. https://travis-ci.org/benjojo/Knwl.js/builds/15537499

Confirmed it has.

It would be nice if we could have tests in the main repo ASAP to prevent people from breaking the library in future. I'm sure that will come soon.

@benjojo benjojo closed this as completed Dec 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjojo @kitten