Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in loading bone morph data #36

Closed
ljghy opened this issue Mar 8, 2023 · 0 comments
Closed

Bug in loading bone morph data #36

ljghy opened this issue Mar 8, 2023 · 0 comments

Comments

@ljghy
Copy link

ljghy commented Mar 8, 2023

At Saba/Model/MMD/PMXModel.cpp line 739:

boneMorphElem.m_rotate = glm::quat_cast(rot1);

the internal order of the quaternion seems inconsistent with that returned from node->GetRotate(), so it goes wrong at PMXModel.cpp line 1268

glm::quat q = glm::slerp(node->GetRotate(), boneMorph.m_rotate, weight);

when interpolating the quaternion.
I tried two versions of glm, the one in this repo and the newest version, and they both have this problem, and the order of the quaternions is not even the same between the two versions.

@ljghy ljghy closed this as completed Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant