Add @foreignConnectionFieldName smart tag
#177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nflection.connectionField(...)` or `inflection.listField(...)` inflector as appropriate. If you are using `@foreignSimpleFieldName` you may be able to delete that now; alternatively you should consider renaming `@foreignFieldName` to `@foreignConnectionFieldName` for consistency.
jvandermey
pushed a commit
to jvandermey/pg-many-to-many
that referenced
this pull request
Feb 8, 2023
By default, use the @manyToManyFieldName to override both connection and simple field names by feeding it to `inflection.connectionField(...)` or `inflection.listField(...)` as appropriate. The field names can be fully overridden (i.e. no additional inflectors applied) with the `@manyToManyConnectionFieldName` or `@manyToManySimpleFieldName` smart comments. This makes the field name override behavior consistent with change introduced in graphile/crystal-pre-merge#177
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea is that by default you just specify
@foreignFieldNameand we feed that intoinflection.connectionField(...)orinflection.listField(...)as appropriate. If you want to override the specific connection field or list field, you can use the@foreignConnectionFieldNameor@foreignSimpleFieldNamerespectively.This is technically a breaking change versus V4, but will only impact you if you override the
connectionFieldinflector to add a suffix/prefix (as is done in@graphile/simplify-inflectionwhenpgOmitListSuffix = true). For consistency, we think this is the right change.