Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul peerDeps again #418

Merged
merged 21 commits into from
Jul 18, 2023
Merged

Overhaul peerDeps again #418

merged 21 commits into from
Jul 18, 2023

Conversation

benjie
Copy link
Member

@benjie benjie commented Jul 17, 2023

Redoing dependencies/peerDependencies around this:

With that being said, Yarn supports "peer dependencies with defaults": if you list a dependency as both a peer and regular dependency, Yarn will use the parent-provided dependency, but will fallback to the regular one if missing. Pnpm supports it too, and I believe even npm supports that somewhat accidentally due to how their "auto-installs" work.

yarnpkg/berry#3710 (comment)

On top of that:

  • I've added a pgl binary package with no peerDeps that can be ran through npx in case everything else fails
  • I've added a bunch more fwds
  • I've revised some of the code to use the fwds

Fixes #411
Fixes #412

@benjie benjie merged commit 6b4b3c6 into planning Jul 18, 2023
@benjie benjie deleted the i-hate-package-managers branch July 18, 2023 09:50
@benjie benjie added this to the V5 beta milestone Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graphile-utils depends on graphile-build Have Grafast export GraphQL, use this everywhere
1 participant