Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghostly events need writing/rewriting #1

Closed
TwelveBaud opened this issue Oct 25, 2017 · 0 comments
Closed

Ghostly events need writing/rewriting #1

TwelveBaud opened this issue Oct 25, 2017 · 0 comments
Assignees
Milestone

Comments

@TwelveBaud
Copy link

If a dwarf is resurrected as a ghost, it triggers a HIST_FIGURE_REVIVED event. This is not displayed in the Death List on the DF-AI report, leading to the apparent impossibility of dwarves dying twice. The event is also stubbed out in the historical figure record. As a first step, this function should probably output a "$hf came back to life as a $df::ghost_type" message.

static void do_event(std::ostream & s, const event_context & context, df::history_event_hist_figure_revivedst *event)

This death message appears when a ghost is removed from play by way of a memorial being created for it, so "put to death" is probably not appropriate, maybe "laid to rest"?

s << " was put to death";

@BenLubar BenLubar self-assigned this Oct 25, 2017
@BenLubar BenLubar added this to the First release milestone Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants