Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swiping still not fixed #7

Closed
ctwist opened this issue Jan 7, 2013 · 6 comments
Closed

Swiping still not fixed #7

ctwist opened this issue Jan 7, 2013 · 6 comments
Labels
bug The issue outlines a clear bug in the existing code which needs to be fixed now, or next release. enhancement The issue contains enhancements or improvements that will be added to future releases.

Comments

@ctwist
Copy link

ctwist commented Jan 7, 2013

Concerning the previous issue, the latest code fix does not work for me. I have deployed the updated version, and now swiping right does not work.

Concerning JSLint, I was not concerned about whitespace, but there are a few missing semicolons. When I run JSLint, I disable the options, "messy whitespace", "== and !=", "misordered definitions", and "many var statements per function". This prevents it from terminating part way through the file, and produces a more manageable error report.

@benmajor
Copy link
Owner

benmajor commented Jan 7, 2013

Can I use the same link that you forwarded earlier? I pushed a new version earlier this morning, and I don't know if the problem is related as I haven't been able to replicate what you're describing.

@ctwist
Copy link
Author

ctwist commented Jan 7, 2013

Yes, use the same link.
I need to sign off. I will be available this evening (5 hours behind GMT).

@benmajor
Copy link
Owner

benmajor commented Jan 7, 2013

I have just checked the link and everything seems to function as expected. Scrolling is enabled, and I can also swipe right to go back. It sounds as though this might be a device-specific issue...

@ctwist
Copy link
Author

ctwist commented Jan 8, 2013

I agree that swiping works correctly on an Android 2.3 tablet, but it doesn't work on a Playbook.

@ctwist
Copy link
Author

ctwist commented Jan 9, 2013

I have stumbled on a solution for the Playbook, but I have no idea why it works. At the end of the touchStart function, add a 100ms pause, i.e.

var dt = new Date();
while ((new Date()) - dt < 100) { }

After adding this, swiping works (and yes, if I remove it, swiping stops working).

@benmajor
Copy link
Owner

benmajor commented Jan 9, 2013

Thanks for the update. Does the interval have to be set to 100ms, or does any value suffice? I wonder if it might be required in order to cause a browser reflow?

I'll close the issue, and look into it more for the next major release. Thank you once again for battling away on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue outlines a clear bug in the existing code which needs to be fixed now, or next release. enhancement The issue contains enhancements or improvements that will be added to future releases.
Projects
None yet
Development

No branches or pull requests

2 participants