Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing parameter to pools.NewResourcePool #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

enriquebris
Copy link

@enriquebris enriquebris commented Jul 22, 2019

On May 25th a 5th parameter was added to function vitess.pools.NewResourcePool (see the commit). This function is invoked as part of newRedisPool and the goworker package doesn't work without this new parameter.

This PR adds 0 as the 5th parameter, meaning the pool won't be pre-filled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants