Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove import/ignore + use UnambiguousJSGrammar #270

Closed
benmosher opened this issue Apr 25, 2016 · 3 comments
Closed

remove import/ignore + use UnambiguousJSGrammar #270

benmosher opened this issue Apr 25, 2016 · 3 comments
Milestone

Comments

@benmosher
Copy link
Member

benmosher commented Apr 25, 2016

Assume any module with at least one import or export (including export {}) is a module.

Ignore any module failing this.

Keep import/ignore for things like ignoring CoffeeScript, but it will be empty by default. Files matching ignore patterns will be completely ignored, as if they were core modules or CJS.

Technically, this is how ignored files work today; if exports are detected, they are parsed anyway. This reversal makes more sense.

Supersedes: #268
Idea thanks to: #384

@benmosher
Copy link
Member Author

related: #268

@benmosher benmosher modified the milestone: next Jul 1, 2016
@benmosher benmosher changed the title remove import/ignore? remove import/ignore + use UnambiguousJSGrammar Jul 1, 2016
@benmosher
Copy link
Member Author

benmosher commented Jul 1, 2016

Original issue text:

Assuming a decent, fast, reliable CommonJS regex can be constructed, import/ignore can potentially cease to exist.

Modules would be ignored if they both

Can't think of why else ignore would be needed.

Definitely a breaking change.

@benmosher
Copy link
Member Author

@jfmengels: let me know what you think of the new issue? if I've missed some key case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant