Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md for #1256 #1277

Merged
merged 5 commits into from
Jan 30, 2019
Merged

Conversation

kirill-konshin
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jan 29, 2019

Coverage Status

Coverage decreased (-0.1%) to 93.971% when pulling 784b602 on kirill-konshin:master into 9bac44e on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.2%) to 97.313% when pulling 2a903db on kirill-konshin:master into 9bac44e on benmosher:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+3.2%) to 97.313% when pulling 2a903db on kirill-konshin:master into 9bac44e on benmosher:master.

Copy link
Member

@benmosher benmosher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually two things:

  • might be good to include a note about installing the typescript parser since it is not an included dependency
  • should it be @eslint/typescript-parser? Isn’t that the current package name?

@kirill-konshin
Copy link
Contributor Author

You're right! In fact, the recommended config should also be updated to this new naming. Hold on ) I will push an update.

@kirill-konshin
Copy link
Contributor Author

Done. Pls squash before merge )))

@benmosher
Copy link
Member

That is my bad for totally failing to remember the right package name off the top of my head 😳

I double-checked just now and updated both to the actual npm name. Thanks for this!

@benmosher benmosher merged commit bdc05aa into import-js:master Jan 30, 2019
@kirill-konshin
Copy link
Contributor Author

kirill-konshin commented Jan 30, 2019

Lol, it happens ) good that it was captured. What's the release ETA? Considering that rename happened just recently it's important to be up to date... NPM version now contains old package...

@marcneander
Copy link

Would love a new release with this 👍

@EvertEt
Copy link

EvertEt commented Feb 4, 2019

Any idea about the ETA for a new version including @eslint/typescript-parser?

@kirill-konshin
Copy link
Contributor Author

Are you guys collecting some additional changes before releasing this? Are there any roadblocks?

@teoxoy
Copy link

teoxoy commented Feb 27, 2019

I would like to see a new version with this too! 👍

@kirill-konshin
Copy link
Contributor Author

Any news regarding the release? Last was on Jan 29... Also there's a fix for #1282 merged this morning...

@mcmar
Copy link

mcmar commented Apr 10, 2019

@ljharb This has been in the README for 3 months now, but it still hasn't been released to npm. As a result, anyone who follows the README on github is getting broken builds.
Reported here: #1285
Can you please do a release?

@ljharb
Copy link
Member

ljharb commented Apr 11, 2019

That’s always a risk; one should check the readme for the latest released tag, not master.

A release will happen when time permits; further commenting doesn’t make that happen any faster.

@kirill-konshin
Copy link
Contributor Author

Just to make it clear, is there any particular reason that holds off the release other than lack of time to do it? Is there any help needed?

@ljharb
Copy link
Member

ljharb commented Apr 11, 2019

That’s pretty much it; it’s not something that i think can be helped at this time, unfortunately.

@kirill-konshin
Copy link
Contributor Author

@ljharb do you mind considering to add more collaborators who can release? No offense, but 2+ months since last release is a lot. Looks like tests are passing but the build is failing, is this the issue that holds release? Are there any other pre-release checks that have to be done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

8 participants