Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] no-unused-modules: fix usage of import/extensions settings #1560

Merged
merged 1 commit into from
Dec 10, 2019
Merged

[Fix] no-unused-modules: fix usage of import/extensions settings #1560

merged 1 commit into from
Dec 10, 2019

Conversation

stekycz
Copy link
Contributor

@stekycz stekycz commented Dec 9, 2019

Fixes #1555

@stekycz stekycz force-pushed the bugfix/no-unused-modules-settings-extensions branch from acc6bd4 to f3189d1 Compare December 9, 2019 11:00
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 96.44% when pulling f3189d1 on stekycz:bugfix/no-unused-modules-settings-extensions into 977da57 on benmosher:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 96.44% when pulling f3189d1 on stekycz:bugfix/no-unused-modules-settings-extensions into 977da57 on benmosher:master.

@coveralls
Copy link

coveralls commented Dec 9, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 96.319% when pulling 4e8960d on stekycz:bugfix/no-unused-modules-settings-extensions into e517739 on benmosher:master.

ljharb
ljharb requested changes Dec 9, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add some tests for JS files as well, perhaps with the .jsx extension?

CHANGELOG.md Show resolved Hide resolved
src/rules/no-unused-modules.js Outdated Show resolved Hide resolved
tests/src/rules/no-unused-modules.typescript.js Outdated Show resolved Hide resolved
@stekycz stekycz force-pushed the bugfix/no-unused-modules-settings-extensions branch from f3189d1 to 13e5c42 Compare December 10, 2019 07:03
@ljharb ljharb force-pushed the bugfix/no-unused-modules-settings-extensions branch from 13e5c42 to fdaf825 Compare December 10, 2019 07:23
@ljharb
Copy link
Member

ljharb commented Dec 10, 2019

Tests seem to be failing in eslint 2-5.

@stekycz stekycz force-pushed the bugfix/no-unused-modules-settings-extensions branch from fdaf825 to 4e8960d Compare December 10, 2019 09:42
@stekycz
Copy link
Contributor Author

stekycz commented Dec 10, 2019

Should be fixed. I have tested it for eslint 2-6 on Node 10 on OSX.

@ljharb ljharb merged commit 4e8960d into import-js:master Dec 10, 2019
kristenmills added a commit to Flexget/webui that referenced this pull request Dec 13, 2019
@kristenmills
Pin eslint-plugin-import until import-js/eslint-plugin-import#1560 is…
b7e6647 
… released
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-unused-modules does not work for modules in files other than .js
3 participants
@stekycz @coveralls @ljharb