Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-unused-rules]: Fix docs for unused exports #1776

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

barbogast
Copy link
Contributor

@barbogast barbogast commented May 21, 2020

First change:
Change

import * from  'file-c'

to

import * as fileC from  'file-c'

The former isn't valid javascript, right?

Second change: Remove example 'file-d', I couldn't see a difference from 'file-c'

Third change: Rename 'file-e' to 'file-d'.

First change: Change `import * from  'file-c'` to `import * as fileC from  'file-c'`. The former isn't valid javascript, right?

Second change: Remove example 'file-d', I couldn't see a difference from 'file-c'

Third change: Rename 'file-e' to 'file-d'.
@coveralls
Copy link

coveralls commented May 21, 2020

Coverage Status

Coverage remained the same at 97.787% when pulling 515957a on barbogast:patch-1 into 0e5bed9 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.738% when pulling dfb3dc6 on barbogast:patch-1 into 3f46ccf on benmosher:master.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems right, thanks

@ljharb ljharb added the docs label Jun 1, 2020
@ljharb ljharb merged commit 515957a into import-js:master Jun 1, 2020
@barbogast barbogast deleted the patch-1 branch June 17, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants