fix-ssl-options-for-tornado #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@tilgovi @berkerpeksag ok as well ? |
|
We should probably add a version check before remove these SSL options. |
|
@berkerpeksag I thought the conclusion from #1135 (comment) was to just merge this and then switch to SSLContext in the future. It doesn't seem like Tornado is going to ever add these options. |
|
what would be the version? |
|
Sorry, I'm getting older :) LGTM |
|
Merged. Thanks all for the feedback! |
mjjbell
pushed a commit
to mjjbell/gunicorn
that referenced
this pull request
Mar 16, 2018
…ornado fix-ssl-options-for-tornado
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1135
All tests were passed, but I did not add tests for this update, sorry.