Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validating ECDSA keys #21

Closed
selmanj opened this issue Apr 26, 2016 · 6 comments
Closed

Validating ECDSA keys #21

selmanj opened this issue Apr 26, 2016 · 6 comments

Comments

@selmanj
Copy link

selmanj commented Apr 26, 2016

I saw that it's not feasible at the moment to implement generating ECDSA keys based on this closed issue: #15

What about adding support to #valid_ssh_public_key? to be able to validate ECDSA keys?

@bensie
Copy link
Owner

bensie commented Apr 27, 2016

I think it's doable, but can't be sure until I dig in. I'll look into it as soon as I can or I'd welcome a PR that adds it.

@selmanj
Copy link
Author

selmanj commented Apr 27, 2016

For reference, I dug in a bit to this. You could probably get pretty strong validation by following the format defined in RFC 5656.

I'd be willing to give it a shot; if I prepared a PR, would you be willing to accept it if I added 'Google Inc.' to the list of authors in the license file?

@bensie
Copy link
Owner

bensie commented May 15, 2016

@selmanj That'd be good with me!

@selmanj
Copy link
Author

selmanj commented Jun 15, 2016

Hoping to come back to this eventually, but I'm not actively working on this yet (in case anyone else wants to submit an implementation).

@mcclymont
Copy link
Contributor

A simple implementation: #24

@bensie
Copy link
Owner

bensie commented Jan 20, 2017

Thanks @mcclymont, closing in favor of #24.

@bensie bensie closed this as completed Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants