Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use scientific notation in rewards #324

Closed
rubenuijtdewilligen opened this issue Nov 21, 2023 · 1 comment
Closed

Don't use scientific notation in rewards #324

rubenuijtdewilligen opened this issue Nov 21, 2023 · 1 comment
Assignees
Labels
Status: Done This issue has been completed or answered. This pull request has been merged.

Comments

@rubenuijtdewilligen
Copy link

Expected behavior

When a large sum of money will be rewarded for completing a challenge, the "Rewards" section of the lore of an item in the challenges GUI should display the amount of money as-is and not with scientific notation.

Observed/Actual behavior

The lore displays the amount of money in scientific notation. I expected this to say 100,000,000.


image

Steps/models to reproduce

Create a challenge with a large sum of money as a reward and look at the lore after running /is challenges.

BentoBox version

Running PAPER 1.19.4.
BentoBox version: 1.24.1
Database: JSON
Loaded Game Worlds:
bskyblock_world (BSkyBlock): Overworld, Nether, The End
Loaded Addons:
Bank 1.7.0 (ENABLED)
Biomes 2.1.1 (ENABLED)
BSkyBlock 1.16.1 (ENABLED)
Challenges 1.2.0 (ENABLED)
ControlPanel 1.13.0 (ENABLED)
DimensionalTrees 1.6.0 (ENABLED)
Level 2.11.0 (ENABLED)
Warps 1.13.0 (ENABLED)

Plugin list

BentoBox
BentoBox-Bank
BentoBox-Biomes
BentoBox-BSkyBlock
BentoBox-Challenges
BentoBox-Level
BentoBox-Warps
BungeeTabListPlus
Essentials
EssentialsChat
EssentialsSpawn
LuckPerms
PlaceholderAPI
PlugManX
TAB-Bridge
Vault
ViaVersion
WorldEdit

Other

No response

@tastybento tastybento self-assigned this Nov 27, 2023
@tastybento tastybento added Status: Under investigation Investigating the interest and the feasability of the issue. Status: In progress Working on the issue. and removed Status: Under investigation Investigating the interest and the feasability of the issue. labels Nov 27, 2023
@tastybento
Copy link
Member

This is fixed but you will need Vault installed (which you have) for the formatting to be used.

@tastybento tastybento added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: In progress Working on the issue. labels Nov 27, 2023
tastybento added a commit that referenced this issue Mar 16, 2024
* Init 1.2.0 version

* Fixes #311 localization errors in zn-CN.

Original translation author translated `[]` placeholders which broke locale

* Init 1.2.0 version

* Edit some unfit translation (#312)

Edit some unfit translation

* Fixes a regex bug that replaced every [player] char instead of whole word.

* Fixes a crash that prevented STATISTICS entity and material/item challenges to be completed.

* Add requirement-not-met-material and requirement-not-met-entity to display statistic required item on error.

* Add locale of Chinese-Hong Kong (zh-HK) (#313)

Addition of locale updated to latest version

* Add ${argLine} to get jacoco coverage

* Updated Jacoco POM section

* Update build.yml

Java 17 for Surefire

* Updated pladdon annotations

* Add support for gamemode-specific translations.

This was a request from Floris

* Update ChallengesManagerTest methods with world parameter.

* Implement option that excludes undeployed challenges

The new option allows to toggle if undeployed challenges should be included in level completion count. Disabling option will not include these challenges for level completion.

Fixes #315

* Create plugin.yml (#316)

* Create plugin.yml

* Update pom.xml

* Update ChallengesPladdon.java

* Remove dependency to org.apache.commons

Replace org.apache.commons.lang.ArrayUtils to a default Java implementation.

* Fixes a crash with written/writable books.

The issue was with generating description message for written books without title or author.

Fixes #318

* Fixed TryToComplete test class

* Fixed CompleteChallengeCommandTest

* Fixed ChallengesCommandTest

* Fixed ChallengesManagerTest

* Update Github Action build script

* Add required distribution

* Fixes the admin GUI crash.

Add shade plugin that was missing for dependencies.

* Update Hungarian translation (#301)

* Translate hu.yml via GitLocalize

* Translate hu.yml via GitLocalize

* Translate hu.yml via GitLocalize

* Translate hu.yml via GitLocalize

* Update hu.yml

Fix color codes and placeholders

---------

Co-authored-by: driverdakid <tamascsiszar99@icloud.com>
Co-authored-by: mt-gitlocalize <mt@gitlocalize.com>
Co-authored-by: BONNe <bonne@bonne.id.lv>
Co-authored-by: slimcraft <davidelek12@gmail.com>
Co-authored-by: tastybento <tastybento@users.noreply.github.com>

* Update POM versions to use latest API

* Remove duplicate plugin reference in POM

* Try adding maven dependency to fix test issue

* Remove offending test. Was not that useful anyway.

* Update Jacoco

* Update pom.xml

* Update to BentoBox 2.0.0

Had to ignore some tests because PowerMockito can't mock them for some
reason.

* Add Ukrainian locale (#326)

* Translate uk.yml via GitLocalize

* Translate uk.yml via GitLocalize

---------

Co-authored-by: mt-gitlocalize <mt@gitlocalize.com>
Co-authored-by: GIGABAIT <freebitcoin93@gmail.com>

* Translate uk.yml via GitLocalize (#325)

Co-authored-by: GIGABAIT <freebitcoin93@gmail.com>
Co-authored-by: tastybento <tastybento@users.noreply.github.com>

* Show money as formatted. Addresses #324

* Update README.md

* Update README.md

* Fixes enchanted book meta not displayed (#328)

Apparently in Spigot EnchantmentStorage has a map that is not used for enchantment storing. Nice.

Fixes #327

* Upgrade PanelUtils to 1.2.0

* Fixes crash when player in CREATIVE shift+clicks on INVENTORY challenge.

Limit completion time to 2, if player is in creative instead of Integer.MAX_VALUE

Fixes #330

* Fix tests for creative user inventory challenge completion

* Update TIPPED_ARROW to latest API in panels

* Update en-US.yml

* Reference latest BentoBox release version

---------

Co-authored-by: BONNe <bonne@bonne.id.lv>
Co-authored-by: EpicMo <1982742309@qq.com>
Co-authored-by: JamesMCL44 <epicquarters@gmail.com>
Co-authored-by: gitlocalize-app[bot] <55277160+gitlocalize-app[bot]@users.noreply.github.com>
Co-authored-by: driverdakid <tamascsiszar99@icloud.com>
Co-authored-by: mt-gitlocalize <mt@gitlocalize.com>
Co-authored-by: slimcraft <davidelek12@gmail.com>
Co-authored-by: GIGABAIT <freebitcoin93@gmail.com>
tastybento added a commit that referenced this issue Aug 10, 2024
* Init 1.2.0 version

* Fixes #311 localization errors in zn-CN.

Original translation author translated `[]` placeholders which broke locale

* Init 1.2.0 version

* Edit some unfit translation (#312)

Edit some unfit translation

* Fixes a regex bug that replaced every [player] char instead of whole word.

* Fixes a crash that prevented STATISTICS entity and material/item challenges to be completed.

* Add requirement-not-met-material and requirement-not-met-entity to display statistic required item on error.

* Add locale of Chinese-Hong Kong (zh-HK) (#313)

Addition of locale updated to latest version

* Add ${argLine} to get jacoco coverage

* Updated Jacoco POM section

* Update build.yml

Java 17 for Surefire

* Updated pladdon annotations

* Add support for gamemode-specific translations.

This was a request from Floris

* Update ChallengesManagerTest methods with world parameter.

* Implement option that excludes undeployed challenges

The new option allows to toggle if undeployed challenges should be included in level completion count. Disabling option will not include these challenges for level completion.

Fixes #315

* Create plugin.yml (#316)

* Create plugin.yml

* Update pom.xml

* Update ChallengesPladdon.java

* Remove dependency to org.apache.commons

Replace org.apache.commons.lang.ArrayUtils to a default Java implementation.

* Fixes a crash with written/writable books.

The issue was with generating description message for written books without title or author.

Fixes #318

* Fixed TryToComplete test class

* Fixed CompleteChallengeCommandTest

* Fixed ChallengesCommandTest

* Fixed ChallengesManagerTest

* Update Github Action build script

* Add required distribution

* Fixes the admin GUI crash.

Add shade plugin that was missing for dependencies.

* Update Hungarian translation (#301)

* Translate hu.yml via GitLocalize

* Translate hu.yml via GitLocalize

* Translate hu.yml via GitLocalize

* Translate hu.yml via GitLocalize

* Update hu.yml

Fix color codes and placeholders

---------

Co-authored-by: driverdakid <tamascsiszar99@icloud.com>
Co-authored-by: mt-gitlocalize <mt@gitlocalize.com>
Co-authored-by: BONNe <bonne@bonne.id.lv>
Co-authored-by: slimcraft <davidelek12@gmail.com>
Co-authored-by: tastybento <tastybento@users.noreply.github.com>

* Update POM versions to use latest API

* Remove duplicate plugin reference in POM

* Try adding maven dependency to fix test issue

* Remove offending test. Was not that useful anyway.

* Update Jacoco

* Update pom.xml

* Update to BentoBox 2.0.0

Had to ignore some tests because PowerMockito can't mock them for some
reason.

* Add Ukrainian locale (#326)

* Translate uk.yml via GitLocalize

* Translate uk.yml via GitLocalize

---------

Co-authored-by: mt-gitlocalize <mt@gitlocalize.com>
Co-authored-by: GIGABAIT <freebitcoin93@gmail.com>

* Translate uk.yml via GitLocalize (#325)

Co-authored-by: GIGABAIT <freebitcoin93@gmail.com>
Co-authored-by: tastybento <tastybento@users.noreply.github.com>

* Show money as formatted. Addresses #324

* Update README.md

* Update README.md

* Fixes enchanted book meta not displayed (#328)

Apparently in Spigot EnchantmentStorage has a map that is not used for enchantment storing. Nice.

Fixes #327

* Upgrade PanelUtils to 1.2.0

* Fixes crash when player in CREATIVE shift+clicks on INVENTORY challenge.

Limit completion time to 2, if player is in creative instead of Integer.MAX_VALUE

Fixes #330

* Fix tests for creative user inventory challenge completion

* Update TIPPED_ARROW to latest API in panels

* Update en-US.yml

* Reference latest BentoBox release version

* Chinese translation (#343)

* Translate zh-CN.yml via GitLocalize

* Translate zh-CN.yml via GitLocalize

* Translate zh-CN.yml via GitLocalize

* Translate zh-CN.yml via GitLocalize

* Translate zh-CN.yml via GitLocalize

---------

Co-authored-by: Jeansou <bettertreebot@gmail.com>
Co-authored-by: CuteLittleSky <2173204318@qq.com>
Co-authored-by: RUYSUE <ruysue@outlook.com>
Co-authored-by: Clexus <528373858@qq.com>
Co-authored-by: mt-gitlocalize <mt@gitlocalize.com>

* French translation (#342)

* Translate fr.yml via GitLocalize

* Translate fr.yml via GitLocalize

* Translate fr.yml via GitLocalize

---------

Co-authored-by: Aksel <afgameytb@gmail.com>
Co-authored-by: organizatsiya <organizatsiya.wildguns@gmail.com>
Co-authored-by: mt-gitlocalize <mt@gitlocalize.com>

* Spanish translation (#341)

* Translate es.yml via GitLocalize

* Translate es.yml via GitLocalize

* Translate es.yml via GitLocalize

---------

Co-authored-by: sergyops <lince885@gmail.com>
Co-authored-by: mt-gitlocalize <mt@gitlocalize.com>
Co-authored-by: Amfetas <artodetodoo@gmail.com>

* Fixes 345 (#346)

Use the object's name if it already has a display name

* return the pladdon that was generated.

* Version 1.3.1

* Translate zh-CN.yml via GitLocalize (#348)

Co-authored-by: RUYSUE <ruysue@outlook.com>

* French translation (#347)

* Translate fr.yml via GitLocalize

* Translate fr.yml via GitLocalize

* Translate fr.yml via GitLocalize

* Translate fr.yml via GitLocalize

---------

Co-authored-by: gitlocalize-app[bot] <55277160+gitlocalize-app[bot]@users.noreply.github.com>
Co-authored-by: Aksel <afgameytb@gmail.com>
Co-authored-by: organizatsiya <organizatsiya.wildguns@gmail.com>
Co-authored-by: mt-gitlocalize <mt@gitlocalize.com>

---------

Co-authored-by: BONNe <bonne@bonne.id.lv>
Co-authored-by: EpicMo <1982742309@qq.com>
Co-authored-by: JamesMCL44 <epicquarters@gmail.com>
Co-authored-by: gitlocalize-app[bot] <55277160+gitlocalize-app[bot]@users.noreply.github.com>
Co-authored-by: driverdakid <tamascsiszar99@icloud.com>
Co-authored-by: mt-gitlocalize <mt@gitlocalize.com>
Co-authored-by: slimcraft <davidelek12@gmail.com>
Co-authored-by: GIGABAIT <freebitcoin93@gmail.com>
Co-authored-by: Jeansou <bettertreebot@gmail.com>
Co-authored-by: CuteLittleSky <2173204318@qq.com>
Co-authored-by: RUYSUE <ruysue@outlook.com>
Co-authored-by: Clexus <528373858@qq.com>
Co-authored-by: Aksel <afgameytb@gmail.com>
Co-authored-by: organizatsiya <organizatsiya.wildguns@gmail.com>
Co-authored-by: sergyops <lince885@gmail.com>
Co-authored-by: Amfetas <artodetodoo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done This issue has been completed or answered. This pull request has been merged.
Projects
None yet
Development

No branches or pull requests

2 participants