Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: To be able to define custom metrics endpoint #4831

Open
bobanj opened this issue Jun 26, 2024 · 5 comments
Open

feature: To be able to define custom metrics endpoint #4831

bobanj opened this issue Jun 26, 2024 · 5 comments
Labels
enhancement Enhancement proposals

Comments

@bobanj
Copy link

bobanj commented Jun 26, 2024

Feature request

Would like to be able to provide something like a prefix_path in the configuration so the metrics, healthz endpoints are
available with my/prefix/path

Motivation

Scenario where multiple models are available under one hostname, ex:

  • my_host/model_1/endpoint
  • my_host/model_2/endpoint
    Would like to be able to access metrics and healthz endpoints without the need to define custom middleware or define additional healthz action (currently in code as far as can be seen, the comparisons are hardcoded ex: == "/metrics". Would like to be able to setup the accessability for these endpoints by defining somehting like prefix_path`:
  • my_host/model_1/metrics
  • my_host/model_1/healthz
  • my_host/model_2/metrics
  • my_host/model_2/healthz

Other

No response

@bobanj bobanj added the enhancement Enhancement proposals label Jun 26, 2024
@ssheng
Copy link
Collaborator

ssheng commented Jun 27, 2024

Are the different models served by one or multiple BentoML servers? If multiple servers, shouldn't they be running on different ports? If the same server, the models should be sharing the same health check path, too. Is my understanding correct?

@bobanj
Copy link
Author

bobanj commented Jun 27, 2024

We are using a diff infra setup (no EKS), hence the reason for asking for this.

@ssheng
Copy link
Collaborator

ssheng commented Jul 2, 2024

@frostming Do you think the health check and metrics prefix is best exposed as a configuration field?

@frostming
Copy link
Contributor

frostming commented Jul 3, 2024

Sorry I didn't get the point. The OP seems to ask for multiple metrics endpoints instead of custom metrics endpoint, but the former doesn't make sense to me.

@bobanj
Copy link
Author

bobanj commented Jul 4, 2024

Not to have multiple metrics endpoints but for the current /metrics path configurable, basically to have something like

if scope["path"] == "/metrics":

if scope["path"] == metrics_path_from_config || "/metrics"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement proposals
Projects
None yet
Development

No branches or pull requests

3 participants