-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement deployment update for sagemaker #461
Merged
Merged
Changes from 19 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
925fa28
add update cli command
yubozhao eaa7cf5
Impl sagemaker update function
yubozhao b781654
add intergration test for update sagemaker deployment
yubozhao 7dd75b9
refactor func for sagemaker e2e
yubozhao 971cde8
add sample_data option for test function
yubozhao 3a08f95
move the funcs into each script so sagemaker wont complain
yubozhao 245caf6
update validation to on par with proto
yubozhao 598e4ee
move func to scripts
yubozhao c836fa6
update
yubozhao 60cd030
include previouse deployment for operator update func
yubozhao 2102c89
update var name and update sagemaker test script
yubozhao e2a7cfd
add testing for sagemaker update
yubozhao a521e2a
add more logger and format
yubozhao 5aaf3cf
remove outdated docstring
yubozhao f424a36
update exception message
yubozhao 3e7141e
fix pep8
yubozhao bc4b04d
add notes
yubozhao 565e61e
move update fields to a list
yubozhao c86ba0c
move steps into try block
yubozhao 896f6c9
update python api
yubozhao d7c2388
fix linter issues
yubozhao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this logic should not be in CLI, move them to yataiservice python_api