Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change float32/uint16 distinction to point/voxel distinction #2

Closed
bergwerf opened this issue Jun 9, 2016 · 1 comment
Closed

Change float32/uint16 distinction to point/voxel distinction #2

bergwerf opened this issue Jun 9, 2016 · 1 comment

Comments

@bergwerf
Copy link
Owner

bergwerf commented Jun 9, 2016

Although float32 is the underlying type to store exact particle coordinates and uint16 is the underlying type to store voxel positions. It is more straightforward if all functions that are specialized to handle a specific type are named using this point/voxel distinction. Example: Domain.containsPoint and Domain.containsVoxel instead of Domain.containsFloat and Domain.containsUint16. The BromiumData.useIntegers boolean and related namings should be converted to useUint16.

@bergwerf
Copy link
Owner Author

This issue is no longer relevant due to #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant