Skip to content
This repository has been archived by the owner on Dec 26, 2017. It is now read-only.

Vagrant doesn't use SemVer #97

Closed
rjocoleman opened this issue Sep 28, 2013 · 2 comments
Closed

Vagrant doesn't use SemVer #97

rjocoleman opened this issue Sep 28, 2013 · 2 comments

Comments

@rjocoleman
Copy link

https://github.com/RiotGames/vagrant-berkshelf/blob/master/lib/berkshelf/vagrant/action/install.rb#L57 uses SemVer to check the running version of Vagrant.

Any 'dev' version e.g. 1.3.4.dev won't work with vagrant-berkshelf.

Related: hashicorp/vagrant#2266

solve-0.8.1/lib/solve/version.rb:20:in `split': '1.3.4.dev' did not contain a valid version string: 'x.y.z' or 'x.y'. (Solve::Errors::InvalidVersionFormat)
@tmatilai
Copy link
Contributor

SemVer allows prerelease version numbers, so that is valid. This is a solve issue.

@reset
Copy link
Contributor

reset commented Sep 28, 2013

Yep, this is a solve issue. I'm going to close this and re-open it on Solve.

@reset reset closed this as completed Sep 28, 2013
@reset reset mentioned this issue Sep 28, 2013
Closed
tmatilai added a commit to tmatilai/vagrant-berkshelf that referenced this issue Sep 30, 2013
@tmatilai
Replace Solve with RubyGems in Vagrant version checking
a80e6dd 
`Solve::Constraint` doesn't support pre-release version numbers[1], so
replace it with `Gem` classes while waiting for a fix.

Fixes berkshelf#97

[1]: berkshelf#97
tmatilai added a commit to tmatilai/vagrant-berkshelf that referenced this issue Sep 30, 2013
@tmatilai
Replace Solve with RubyGems in Vagrant version checking
3e84acc 
`Solve::Constraint` doesn't support pre-release version numbers[1], so
replace it with `Gem` classes while waiting for a fix.

Fixes berkshelf#97

[1]: berkshelf/solve#29
@tmatilai tmatilai mentioned this issue Sep 30, 2013
Merged
tmatilai added a commit to tmatilai/vagrant-berkshelf that referenced this issue Dec 11, 2013
@tmatilai
Replace Solve with RubyGems in Vagrant version checking
3fe253e 
`Solve::Constraint` doesn't support pre-release version numbers[1], so
replace it with `Gem` classes while waiting for a fix.

Fixes berkshelf#97

[1]: berkshelf/solve#29
@berkshelf berkshelf locked and limited conversation to collaborators Jun 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@reset @tmatilai @rjocoleman