Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a email like username will cause error #5

Closed
aulian opened this issue Mar 27, 2015 · 4 comments
Closed

a email like username will cause error #5

aulian opened this issue Mar 27, 2015 · 4 comments
Assignees
Labels

Comments

@aulian
Copy link

aulian commented Mar 27, 2015

a email like username (like bob@gmail.com) will cause error

webdav-sync --local_base /var/src/code --remote_base "https://bob@gmail.com:pass@demandware.com/webdav/"
@bensmoif
Copy link
Collaborator

Dang, I thought we fixed this a few releases ago. I'll look into it and hopefully have it patched by weeks end! Thanks Aulian.

@bensmoif bensmoif self-assigned this Mar 30, 2015
@bensmoif bensmoif added the Bug label Mar 30, 2015
@aulian
Copy link
Author

aulian commented Apr 1, 2015

look forward your brillant work

@bensmoif
Copy link
Collaborator

In reviewing: to support this we'll have to add two new options for username and password distinct from --remote_path="https://username:passwd@really-long-and-ugly-login-string.com/webdavdrop/"

I wish this was something we'd caught earlier in the dev process, it might require a major version change in the end to do it cleanly

@bensmoif
Copy link
Collaborator

@aulian: This is now fixed, and pretty cleanly. We now have --username and --password options for secure login that will accept any special characters. Please test and let me know if you have any issues with the new 0.4.4 release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants