Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Puppeteer-Firefox #55

Closed
alexjohndoe opened this issue Aug 1, 2019 · 4 comments
Closed

Support Puppeteer-Firefox #55

alexjohndoe opened this issue Aug 1, 2019 · 4 comments
Labels
enhancement New feature or request planned-feature Will be added in a future release

Comments

@alexjohndoe
Copy link

Is it possible to support Puppeteer-Firefox? Thanks.

@berstend
Copy link
Owner

berstend commented Nov 24, 2019

Hey there, I neglected this project a bit and will do some hygiene first (updating deps, etc) and refactor the core to TS. Afterwards I'll look into the effort needed to support FF as well :)

@berstend berstend added the enhancement New feature or request label Nov 24, 2019
@berstend
Copy link
Owner

berstend commented Nov 25, 2019

This is a good overview about what's already supported in Puppeteer-Firefox:
https://aslushnikov.github.io/ispuppeteerfirefoxready/

Looks pretty decent, most plugins should theoretically work with FF as well.

@berstend berstend added the planned-feature Will be added in a future release label Nov 25, 2019
@alexjohndoe
Copy link
Author

awesome 👍

@berstend
Copy link
Owner

@chanjsq I've added addExtra support while rewriting the core in TypeScript, this is now supported (I just published v3.1.3):

const { addExtra } = require('puppeteer-extra')
const puppeteer = addExtra(require('puppeteer-firefox'))

puppeteer.launch({ headless: false }).then(async browser => {
  const page = await browser.newPage()
  await page.setViewport({ width: 800, height: 600 })

  await page.goto('https://www.spacejam.com/archive/spacejam/movie/jam.htm')
  await page.waitFor(10 * 1000)

  await browser.close()
})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request planned-feature Will be added in a future release
Projects
None yet
Development

No branches or pull requests

2 participants