Improved asset.pipeline.utils.net.Urls + code & config cleanup #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacing tabs parentheses quotes
changed from groovy to java improved javadocs added static methods: concatenateUrl(...) getDefaultPort(String) getUrlSansScheme(String) hasAuthority(String) withScheme(*) added constant Patterns: HAS_AUTHORITY_URL_PATTERN URL_COMPONENT_PATTERN reuse URL_SCHEME_SANS_COLON_REGEX for Patterns, which uses possessive regex for performance use tabs
This was referenced Oct 4, 2015
|
may fix some standardization of formatting in this but ill def merge it. doing new lines a bit excessively on if statements. just a style preference and trying to keep things consistent |
davydotcom
added a commit
that referenced
this pull request
Oct 4, 2015
Improved asset.pipeline.utils.net.Urls + code & config cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains the changes listed below:
asset.pipeline.utils.net.Urlswith Java version that includes more methods & constants (that are used by my corresponding new version of AP)Stringliteral instead ofGString